Add first functional tests #153
Conversation
The XDEBUG variables defined in the docker-compose.yml file command blocks were not used under docker 20.10.24+dfsg1 with docker compose version v2.29.2. This led to the problem that Bootstrap::init took 37 seconds, wasting developer time. By switching to "export" calls, the variables get set properly and php/xdebug runs fast. A single functional test run is 3 seconds now.
based on the files in Tests/Functional/Bucketfiles/
Created with the Build/testing-docker/prepare-minio-data.sh Committed here so that "mc" (minio client) is not needed to run the tests.
./Build/Scripts/runTests.sh -p 8.2 -d sqlite -s functional -e "--display-warnings --display-notices --display-errors"
We use a local minio instance to run the tests against. Run them with ./Build/Scripts/runTests.sh -p 8.2 -d sqlite -s functional -e "--display-warnings --display-notices --display-errors"
|
I've added the functional tests to the github actions file, but they do not run automatically:
|
- amend commit to trigger build
cweiske
force-pushed
the
functional-tests
branch
from
f0da656 to
d9fa566
Compare
ubuntu-20.04 brings an error: > Run Build/Scripts/runTests.sh -p 8.0 -s composerInstall > Build/Scripts/runTests.sh: line 107: type: docker-compose: not found > This script relies on docker and docker-compose. Please install
.. typo3/testing-framework 8 needs a higher version
|
The tests run! |
|
Thank you @cweiske |
|
Ok, where is the new PR? |
|
I pushed it to https://github.com/andersundsehr/aus_driver_amazon_s3/tree/functional-tests-alternative feel free to tell me if there are reasons not to do as i did. |
|
Did you change my commits? I don't see any commits of yours. I used a set of predefined files in minio because that makes the test runs faster. |
|
@cweiske you are right. the commit did not succeed it is now added. i hope i have some time soon to get things together and have a master merge |
|
@weakbit could you please merge the tests as they are, so that the other patches can use the tests as base? I understand if you want to change things, but they do work as they are. Having non-optimal tests now is better than perfect ones in 3 year. |
This adds the first functional tests for
aus_driver_amazon_s3.The tests are run against a local MinIO instance that is started with the container that the tests are run in.
A prepared
test-bucketis provided that MinIO can use without initial setup, which keeps test setup time low and keeps dependencies at minimum.Some of the tests are marked skipped because they exhibit bugs that get fixed with #147.
The functional tests do not yet get automatically run on github actions since I don't know how to do that properly.
I run the tests locally with
and they complete in 3 seconds.